Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding visual cue for "Limited" & "Private" organizations. #13040

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Adding visual cue for "Limited" & "Private" organizations. #13040

merged 3 commits into from
Oct 6, 2020

Conversation

spenaustin
Copy link
Contributor

Implements #13017 .

Label for "Limited" & "Private" organizations added to org header, org homepage, and navbar.

Before:

Screen Shot 2020-10-05 at 4 06 59 PM Screen Shot 2020-10-05 at 4 06 49 PM

After:

Screen Shot 2020-10-05 at 4 06 07 PM Screen Shot 2020-10-05 at 4 07 30 PM Screen Shot 2020-10-05 at 4 21 25 PM Screen Shot 2020-10-05 at 4 21 18 PM Screen Shot 2020-10-05 at 4 06 28 PM Screen Shot 2020-10-05 at 4 07 20 PM

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #13040 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13040      +/-   ##
==========================================
+ Coverage   42.57%   42.61%   +0.04%     
==========================================
  Files         672      672              
  Lines       73698    73785      +87     
==========================================
+ Hits        31374    31445      +71     
- Misses      37241    37248       +7     
- Partials     5083     5092       +9
Impacted Files Coverage Δ
modules/secret/secret.go 74.07% <0.00%> (-9.26%) ⬇️
modules/setting/task.go 72.72% <0.00%> (-7.28%) ⬇️
modules/setting/queue.go 71.42% <0.00%> (-4.77%) ⬇️
routers/repo/attachment.go 42.85% <0.00%> (-3.38%) ⬇️
modules/context/auth.go 18.47% <0.00%> (-2.58%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/indexer/issues/bleve.go 69.28% <0.00%> (-1.43%) ⬇️
models/issue_label.go 67.15% <0.00%> (-0.76%) ⬇️
models/issue.go 56.58% <0.00%> (-0.07%) ⬇️
services/pull/review.go 47.74% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72636fd...17fbba7. Read the comment docs.

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Oct 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 5, 2020
6543
6543 requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realy like how it looks like ...

two TODO's:

  • move inline css to less files
  • public repos in limited orgs are limited too

templates/org/header.tmpl Outdated Show resolved Hide resolved
@spenaustin
Copy link
Contributor Author

@6543 Moved styles to .less files in commit 17fbba7 . Re: repository "Limited" labels -- do we want to find some way to visually show that the "Limited" attribute/label is inherited from the org (opposed to the "Private" attribute, which is set at the repository level & also creates a label next to the repo name)?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick
Copy link
Member

@6543 I think the 2nd one can be saved for later PR

@techknowlogick techknowlogick merged commit 6eea301 into go-gitea:master Oct 6, 2020
@spenaustin spenaustin mentioned this pull request Oct 6, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 requested changes

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@spenaustin @codecov-commenter @techknowlogick @zeripath @6543 @GiteaBot